Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Conversation

wtam2018
Copy link
Collaborator

@wtam2018 wtam2018 commented Jul 13, 2022

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
This PR update the SHA of gitops-commit-status container image to pick up v0.0.2 which includes multi arch supports (amd64, ppc64le and s390x)

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-2162
Fixes #?

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from chetan-rns and keithchong July 13, 2022 18:24
@@ -28,7 +28,7 @@ func CreateCommitStatusTask(namespace string) *pipelinev1.Task {
{
Container: v1.Container{
Name: "set-commit-status",
Image: "quay.io/redhat-developer/gitops-commit-status@sha256:ef5b3b242bf3b42a3a5d3ff74b3c7d495c608297b7428ae57b8ece10954e7546",
Image: "quay.io/redhat-developer/gitops-commit-status@sha256:bce4bd73d5394551f0640a6f07f5fef6d5d54bbf201c3d9b5ecc9a7ff86dd988",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the shasum of the manifest list:

Suggested change
Image: "quay.io/redhat-developer/gitops-commit-status@sha256:bce4bd73d5394551f0640a6f07f5fef6d5d54bbf201c3d9b5ecc9a7ff86dd988",
Image: "quay.io/redhat-developer/gitops-commit-status@sha256:b28e5d207f70fc37f5cbf79fabcfa2708459316d09e9def9647c06807d9464cd",

@yselkowitz
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

@yselkowitz: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ishitasequeira
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ishitasequeira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@ishitasequeira ishitasequeira self-requested a review July 13, 2022 20:11
@openshift-ci openshift-ci bot merged commit 8baf252 into redhat-developer:master Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants