New Rector rule to replace string literal argument values with class constants

[JohJohan]

I’d like to propose a new Rector rule (or at least start a discussion) to automatically replace certain string literal argument values with class constants.

Examples
Example 1: Symfony WebLink

-new Link('preload');
+new Link(Link::REL_PRELOAD);

Example 2: Symfony HttpFoundation Cookie

-return Cookie::create($name, $value, new DateTime('+1 month'), '/', null, true, false, false, 'strict');
+return Cookie::create($name, $value, new DateTime('+1 month'), '/', null, true, false, false, Cookie::SAMESITE_STRICT);

A recent Symfony commit that hints to use constants:
symfony/symfony-docs@abc8d69

[samsonasik]

You can use ReplaceArgumentDefaultValueRector for that, see https://getrector.com/demo/0251472e-efb6-470a-abb5-5fd10179a14c

[JohJohan]

Nice one, i tried it out but doesn't seem to work with multiple replacements which i wanted to add For Symfony with the Link example see try: https://getrector.com/demo/906a94e8-6c68-4668-b958-13abe1b31f57 preconnect is not replaced

[samsonasik]

The rule seems works on once and forgot https://getrector.com/demo/677727f1-66c7-423e-9450-92abc530c36f , probably needs improvement tho :)

[JohJohan]

Aha i see nice catch, that would indeed be a improvement for ReplaceArgumentDefaultValueRector but i know i can go ahead with my changes for Link in Symfony.

I think next week i will create bug/improvement ticket for ReplaceArgumentDefaultValueRector or you guys can if you feel like it