Skip to content

[Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 3 commits into from
Aug 5, 2025
Merged

[Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector #7109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa352bf
[Php80] Skip not match property hook type with parameter type on Clas…
samsonasik Aug 5, 2025
01d3fe1
eol
samsonasik Aug 5, 2025
2e48ff1
fix per use case
samsonasik Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...pertyAssignToConstructorPromotionRector/Fixture/skip_not_match_property_hook_type.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\Fixture;

class SkipNotMatchPropertyHookType {
protected \stdClass $origin {
set(array|\stdClass $origin) {
$this->origin = is_array($origin) ? (object) $origin : clone $origin;
}
}

public function __construct(
array|\stdClass $origin
) {
$this->origin = $origin;
}
}
7 changes: 7 additions & 0 deletions rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ public function refactor(Node $node): ?Node
continue;
}

if ($property->type instanceof Node
&& $param->type instanceof Node
&& $property->hooks !== []
&& ! $this->nodeComparator->areNodesEqual($property->type, $param->type)) {
continue;
}

$hasChanged = true;

// remove property from class
Expand Down
Loading