Skip to content

Fix crash on ExactCompareFactory::createBooleanAnd/Or #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Fix crash on ExactCompareFactory::createBooleanAnd/Or #7031

merged 1 commit into from
Jun 30, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

@shakaran @AndreiOrmanji let see if this can fix rectorphp/rector#9113 , it is hard to verify on unit test tho, just verify to return null if not match with return type.

@samsonasik samsonasik merged commit fa01afc into main Jun 30, 2025
46 checks passed
@samsonasik samsonasik deleted the fix-crash-3 branch June 30, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System error: "Rector\Strict\NodeFactory\ExactCompareFactory::createBooleanAnd(): Return value
1 participant
@samsonasik