[DeadCode] Skip abstract method on RemoveUnusedPublicMethodParameterRector #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Jun 19, 2025
|
|
||
| namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPublicMethodParameterRector\FixtureTreatClassesAsFinal; | ||
|
|
||
| abstract class SkipAbstractMethod |
There was a problem hiding this comment.
@TomasVotruba abstract method only exists in abstract class, this means in other rules, the check $class->isAbstract() is needed as well, since abstract never be "final".
There was a problem hiding this comment.
I will create separate PR for add is abstract check on "treat final class" since abstract never be "final"
There was a problem hiding this comment.
I created separate PR for always verify class is abstract before FeatureFlags::treatClassesAsFinal() check at PR:
samsonasik
commented
Jun 19, 2025
Comment on lines
-20
to
-23
| public static function reset(): void | ||
| { | ||
| SimpleParameterProvider::setParameter(Option::TREAT_CLASSES_AS_FINAL, false); | ||
| } |
There was a problem hiding this comment.
I just moved this reset functionality to AbstractRectorTestCase::tearDownAfterClass
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happen when
->withTreatClassesAsFinal();is used, which non-final class can have abstract method to be implemented by child.