Skip to content

[Php84] Add NewMethodCallWithoutParenthesesRector #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2025
Merged

[Php84] Add NewMethodCallWithoutParenthesesRector #6802

merged 4 commits into from
Mar 21, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

implemented 🎉 /cc @ruudk @gnutix

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

ruudk
ruudk approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this Rector on our project and it works great. Nice 🎉

@TomasVotruba
Copy link
Member

@ruudk Thank you for prompt testing 👍

Lets ship it 😉

@TomasVotruba TomasVotruba merged commit 07f5cc6 into main Mar 21, 2025
44 checks passed
@TomasVotruba TomasVotruba deleted the php84-new-method-call-without-parentheses branch March 21, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

+1 more reviewer

@ruudk ruudk ruudk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PHP 8.4] new MyClass()->method() without parentheses
3 participants
@samsonasik @TomasVotruba @ruudk