Skip to content

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @koraga

@samsonasik
Copy link
Member Author

samsonasik commented Feb 28, 2025

@TomasVotruba rector-symfony, rector-phpunit somehow error, it may related with change on your PR on rector-doctrine

I will look into it

@samsonasik
Copy link
Member Author

it really strange, while code unrelated, use rector-src dev-main no issue, but this branch cause error, even no code change

➜  rector-phpunit git:(main) vendor/bin/phpunit 
PHPUnit 11.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.27
Configuration: /home/abdul/www/rector-phpunit/phpunit.xml

...............................................................  63 / 349 ( 18%)
............................................................... 126 / 349 ( 36%)
............................................................... 189 / 349 ( 54%)
............................................................... 252 / 349 ( 72%)
............................................................... 315 / 349 ( 90%)
..................................                              349 / 349 (100%)

Time: 00:09.931, Memory: 192.50 MB

OK (349 tests, 425 assertions)

with this branch:

➜  rector-phpunit git:(main) composer up       
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading rector/rector-src (dev-main 008cae3 => dev-skip-prop-hoko 539d469)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
No patches supplied.
Gathering patches for dependencies. This might take a minute.
  - Upgrading rector/rector-src (dev-main 008cae3 => dev-skip-prop-hoko 539d469): Extracting archive
Generating autoload files
55 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
No security vulnerability advisories found.
➜  rector-phpunit git:(main) ✗ vendor/bin/phpunit
PHPUnit 11.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.27
Configuration: /home/abdul/www/rector-phpunit/phpunit.xml

.F.............................................................  63 / 349 ( 18%)
............................................................... 126 / 349 ( 36%)
............................................................... 189 / 349 ( 54%)
............................................................... 252 / 349 ( 72%)
............................................................... 315 / 349 ( 90%)
..................................                              349 / 349 (100%)

Time: 00:11.830, Memory: 192.50 MB

There was 1 failure:

1) Rector\PHPUnit\Tests\AnnotationsToAttributes\AnnotationsToAttributesTest::test with data set #1 ('/home/abdul/www/rector-phpuni...hp.inc')
Failed on fixture file "inline_docblock_tag.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 /**
  * @copyright Example {@link https://example.com}
+ * @covers \Tests\BarController
  */
-#[\PHPUnit\Framework\Attributes\CoversClass(\Tests\BarController::class)]
 class BarController extends TestCase
 {
 }

/home/abdul/www/rector-phpunit/vendor/rector/rector-src/src/Testing/PHPUnit/AbstractRectorTestCase.php:249
/home/abdul/www/rector-phpunit/vendor/rector/rector-src/src/Testing/PHPUnit/AbstractRectorTestCase.php:165
/home/abdul/www/rector-phpunit/tests/AnnotationsToAttributes/AnnotationsToAttributesTest.php:16

FAILURES!
Tests: 349, Assertions: 426, Failures: 1.

@samsonasik
Copy link
Member Author

It probably composer glitch or phpstan doc preload issue, I will look more

@samsonasik
Copy link
Member Author

Ok, it seems rebase is needed, it somehow not detected by github

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit efef8ac into main Feb 28, 2025
44 checks passed
@samsonasik samsonasik deleted the skip-prop-hoko branch February 28, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ReadOnlyPropertyRector
1 participant