Skip to content

[AutoImport] Handle FQCN with sub namespace #6672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[AutoImport] Handle FQCN with sub namespace #6672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cc971
[AutoImport] Handle FQCN with sub namespace
samsonasik Jan 16, 2025
13c512e
Fix
samsonasik Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/CodingStyle/Application/UseImportsAdder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,6 @@ private function isCurrentNamespace(string $namespaceName, ObjectType $objectTyp
return false;
}

return ! \str_contains($afterCurrentNamespace, '\\');
return $namespaceName . '\\' . $afterCurrentNamespace === $objectType->getClassName();
}
}
21 changes: 21 additions & 0 deletions tests/Issues/AutoImport/Fixture/fqcn_with_subnamespace.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

namespace helpers;

class Dum extends \yii\helpers\VarDumper
{
}

?>
-----
<?php

namespace helpers;

use yii\helpers\VarDumper;

class Dum extends VarDumper
{
}

?>
Loading