feature: replace MyCLabs Enum constructor call #6588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
carlosvinicius
force-pushed
the
feature/replace-myclabs-enum-constructor-call
branch
from
158efc5 to
ca5a6d2
Compare
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
carlosvinicius
force-pushed
the
feature/replace-myclabs-enum-constructor-call
branch
from
ca5a6d2 to
f4cd998
Compare
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 14, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 16, 2024
rules/Php81/Rector/New_/MyCLabsConstructorCallToEnumFromRector.php
Outdated
Show resolved
Hide resolved
carlosvinicius
force-pushed
the
feature/replace-myclabs-enum-constructor-call
branch
from
e77a7cf to
6e76750
Compare
samsonasik
approved these changes
Jan 11, 2025
|
Thank you 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The My C-Labs enum allows instantiation as a class using
newinstead of the static methodfrom. (ref).As it is not applicable for native enums, this PR allows the enum instantiations that use the
newstatement to be replaced by the static methodfrom.Enums that override the default My C-Labs enum constructor are skipped.