Skip to content

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 5, 2025

Fixes BC break in case of non-test TestCase class use, ref sebastianbergmann/phpunit@705874f

Ref sebastianbergmann/phpunit#3975

@TomasVotruba TomasVotruba force-pushed the tv-parent-ctor branch 2 times, most recently from 72e2da7 to c1e5d5b Compare May 5, 2025 16:19
@TomasVotruba TomasVotruba enabled auto-merge (squash) May 5, 2025 16:19
@TomasVotruba TomasVotruba disabled auto-merge May 5, 2025 16:37
@TomasVotruba TomasVotruba force-pushed the tv-parent-ctor branch 2 times, most recently from be7357e to 1b20777 Compare May 5, 2025 16:42
@TomasVotruba
Copy link
Member Author

Let's see how many edge-cases there will be in the wild 🚢

@TomasVotruba TomasVotruba merged commit 4820350 into main May 5, 2025
6 checks passed
@TomasVotruba TomasVotruba deleted the tv-parent-ctor branch May 5, 2025 17:05
@samsonasik
Copy link
Member

samsonasik commented May 20, 2025

@TomasVotruba it seems constructor is marked as final since phpunit 12.0.3 so I think the rule ParentTestClassConstructorRector itself can be removed.

ref issue :

ref phpunit diff sebastianbergmann/phpunit@3263f4c

@samsonasik
Copy link
Member

I created PR:

for it.

@samsonasik
Copy link
Member

I created new PHPUnit 12 rule PR for it:

to remove __construct on phpunit 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants