Ensure that rule PreferPHPUnitSelfCall refactor call only for static methods, not any #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

TomasVotruba merged 9 commits into rectorphp:main from andrew-demb:make-static-only-static-methods

May 2, 2025

Contributor

andrew-demb commented May 2, 2025 •

edited by samsonasik

Loading

Closes rectorphp/rector#9138

andrew-demb added 3 commits

May 2, 2025 13:40


          📦 Move check for static above the method reflection resolving logic

a3a4def

Avoid unnecessary resolving


          🐛 [9138] Ensure that rule PreferPHPUnitSelfCall refactor call only …

3251eb7

…for static methods, not any

rectorphp/rector#9138


          📖 [9138] Explain fixture behavior with comment

1980c36

rectorphp/rector#9138

andrew-demb mentioned this pull request

Incorrect behavior of PreferPHPUnitSelfCallRector, PreferPHPUnitThisCallRector rectorphp/rector#9138

Closed

samsonasik reviewed

View reviewed changes

...sts/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/include_exceptions.php.inc Outdated Show resolved Hide resolved

samsonasik reviewed

View reviewed changes

rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php Outdated Show resolved Hide resolved


          📦 Rename fixture to be clear about semantics

9dcb0e3

samsonasik reviewed

View reviewed changes

...odeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/skip_include_exceptions.php.inc Outdated Show resolved Hide resolved

samsonasik reviewed

View reviewed changes

...odeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/skip_include_exceptions.php.inc Outdated Show resolved Hide resolved

andrew-demb added 2 commits

May 2, 2025 15:41


          📦 Rename class in fixture to be consistent with filename

65908dd


          📦 Rename fixture file

35f0032

samsonasik reviewed

View reviewed changes

rules/CodeQuality/Enum/NonAssertPrefixedAssertionMethods.php Outdated Show resolved Hide resolved


          📦 Rename enum to ensure that there is no static methods inside, check…

… for static call before checking with enum

As suggested in review comment #482 (comment)

samsonasik approved these changes

View reviewed changes

Member

samsonasik commented May 2, 2025

I will let @TomasVotruba decide on this ;)

samsonasik requested a review from TomasVotruba

May 2, 2025 13:56


          📦 Rename enum to be clear about semantics and short

ce1d4d6

As suggested in the review comment #482 (comment)

samsonasik reviewed

View reviewed changes

rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php Outdated Show resolved Hide resolved


          📦 Revert check for static call as unneeded here

1b83816

As of review comment #482 (comment)

samsonasik approved these changes

View reviewed changes

TomasVotruba approved these changes

View reviewed changes

Member

TomasVotruba commented May 2, 2025

Awesome work, thank you 👍

TomasVotruba merged commit ab9e383 into rectorphp:main

6 checks passed

andrew-demb deleted the make-static-only-static-methods branch

May 2, 2025 15:05

samsonasik mentioned this pull request

PreferPHPUnitSelfCallRector, PreferPHPUnitThisCallRector missing some static methods rectorphp/rector#9198

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet