Skip to content

Conversation

samsonasik
Copy link
Member

It seems due to this change phpstan/phpstan-src@3854cbc

It seems the only way we can do is just follow it since it not error when set as magic https://3v4l.org/IrE2q#v7.4.33

This PR update the fixture.

@samsonasik samsonasik enabled auto-merge (squash) May 2, 2025 17:23
@samsonasik samsonasik merged commit 246c7a7 into main May 2, 2025
6 checks passed
@samsonasik samsonasik deleted the update-fixture-tostring branch May 2, 2025 17:23
@TomasVotruba
Copy link
Member

Will this cause any bugs?
It seems the rule adds string everywhere now

@samsonasik
Copy link
Member Author

it is ok, since __toString() is magic, see https://3v4l.org/IrE2q#v7.4.33

@samsonasik
Copy link
Member Author

@TomasVotruba ok, if it has another child, than it cause error if not downgraded (shippped product that downgraded - consumed by user), I will update to use AstResolver for it on separate PR

@samsonasik
Copy link
Member Author

samsonasik commented May 2, 2025

@TomasVotruba possible bug if downgraded code consumed by user https://3v4l.org/kdcEh#v7.4.33

I will create separate PR with AstResolver 👍

@samsonasik
Copy link
Member Author

samsonasik commented May 2, 2025

@TomasVotruba
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants