Bad filename encoding breaking rom list view

[sveetch]

Seems at least on the rom list view, but probably on bios too.

[sveetch]

Ok i can't reproduce the bug, it's not an unicode problem because it works nice even with filename written in Kana and probably with every valid unicode (symbols, Cyrillic, etc..).

What i think it's than the user has uploaded files (at least one) with corrupted encoding filename. Until i can reproduce it, i will just put an exception safe block to simply ignore corrupted filename so it does not affect the list process.

Hey @neolao @pasnox @digitalLumberjack @MikaXII @rockaddicted could you help me and try to reproduce it ? Thanks

[pasnox]

Partly easy - mount a ntfs iso latin file system as utf8 on linux. Should
present broken encoding.
On 20 Dec 2015 00:14, "David THENON" notifications@github.com wrote:

Ok i can't reproduce the bug, it's not an unicode problem because it works
nice even with filename written in Kana and probably with every valid
unicode (symbols, Cyrillic, etc..).

What i think it's than the user has uploaded files (at least one) with
corrupted encoding filename. Until i can reproduce it, i will just put an
exception safe block to simply ignore corrupted filename so it does not
affect the list process.

Hey @neolao https://github.com/neolao @pasnox
https://github.com/pasnox @digitalLumberjack
https://github.com/digitalLumberjack @MikaXII
https://github.com/MikaXII @rockaddicted
https://github.com/rockaddicted could you help me and try to reproduce
it ? Thanks

—
Reply to this email directly or view it on GitHub
#39 (comment)
.

[sveetch]

@pasnox oh thanks for the info.

This is pretty difficult for me to reproduce this since i dont have any ntfs nor latin file system FS

[sveetch]

Ok, well for now i will consider this as a "wont fix", will notify about in the README and keeping this bug issue open until 1.2.0, and will close it if not any news

[tlanks]

import sys
default_encoding = 'utf-8'
if sys.getdefaultencoding() != default_encoding:
reload(sys)
sys.setdefaultencoding(default_encoding)

[tlanks]

https://docs.python.org/2/howto/unicode.html

[sveetch]

@tlanks i dont really understand what you mean, just know that nowadays we are almost full unicode, and utf-8 is mostly used for output formatting.

All in all, your code wont change anything even if i was able to reproduce the bug on my recalbox.