feat(TableOfContents): add prop to control TOC heading label #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinports
commented
Oct 8, 2025
| Toc: (props: { heading?: string }) => | ||
| Toc ? ( | ||
| <Components.TableOfContents> | ||
| <Toc {...props} /> |
Contributor
Author
There was a problem hiding this comment.
I don't think there are actually any props getting passed in here?
kevinports
commented
Oct 8, 2025
| }, | ||
| ]; | ||
|
|
||
| describe.skip('Table of Contents', () => { |
Contributor
Author
There was a problem hiding this comment.
Removed skipping the whole block and moved to the failing cases so a few passing test cases can be included.
kellyjosephprice
approved these changes
Oct 8, 2025
rafegoldberg
pushed a commit
that referenced
this pull request
Oct 8, 2025
Contributor
|
This PR was released!🚀 Changes included in v11.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Add
headingprop to theContent.Toccomponent so we can control it in the React app for internationalization🧬 QA & Testing