Skip to content

feat: dropping support for node 16 + esm compat #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erunion merged 12 commits into from
Sep 14, 2023
Merged

feat: dropping support for node 16 + esm compat #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
01a562c
feat: dropping support for node 16
erunion Sep 12, 2023
9aa6caf
feat: esm compatibility
erunion Sep 12, 2023
f2bad27
feat: better support for esm snippets
erunion Sep 13, 2023
11ac38a
fix: typo
erunion Sep 13, 2023
579177f
fix: broken integration tests
erunion Sep 13, 2023
9579e1b
fix: integration suite fixes
erunion Sep 13, 2023
2ec8614
fix: node application-json tests
erunion Sep 13, 2023
e59e96c
ci: debug
erunion Sep 13, 2023
ccc9824
ci: debug
erunion Sep 13, 2023
89e7cf8
ci: fixing js tests
erunion Sep 13, 2023
c5d5cc9
chore: bumping eslint-config
erunion Sep 13, 2023
c8d9044
fix: running linting on cjs files
erunion Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
{
"extends": [
"@readme/eslint-config",
"@readme/eslint-config/esm",
"@readme/eslint-config/typescript",
"@readme/eslint-config/testing/jest"
"@readme/eslint-config/testing/vitest"
],
"root": true,
"parserOptions": {
"ecmaVersion": 2020
},
"rules": {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-use-before-define": "off",
Expand All @@ -20,8 +18,18 @@
"no-underscore-dangle": ["error", { "allow": ["_boundary"] }],
"spaced-comment": "off",

"unicorn/prefer-node-protocol": "error"
"unicorn/prefer-node-protocol": "error",

"vitest/require-hook": "off"
},
"overrides": [
{
"files": ["src/fixtures/**"],
"rules": {
"import/no-commonjs": "off"
}
}
],
"env": {
"browser": true
}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
strategy:
matrix:
node-version:
- 16
- 18
- 20

Expand Down
14 changes: 7 additions & 7 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ services:
build:
context: .
dockerfile: integrations/node.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=node
Expand All @@ -48,7 +48,7 @@ services:
build:
context: .
dockerfile: integrations/php.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=php
Expand All @@ -60,7 +60,7 @@ services:
build:
context: .
dockerfile: integrations/python.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
Copy link
Member Author

@erunion erunion Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to use the run command here because Vitest doesn't know in this Docker container that it's being run in a CI environment and it'll sit there in watch mode.

environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=python
Expand All @@ -73,7 +73,7 @@ services:
build:
context: .
dockerfile: integrations/shell.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=shell
Expand All @@ -85,7 +85,7 @@ services:
build:
context: .
dockerfile: integrations/csharp.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=csharp
Expand All @@ -97,7 +97,7 @@ services:
build:
context: .
dockerfile: integrations/c.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=c
Expand All @@ -109,7 +109,7 @@ services:
build:
context: .
dockerfile: integrations/go.Dockerfile
command: 'npx jest src/integration.test.ts'
command: 'npx vitest run src/integration.test.ts'
environment:
- HTTPBIN=true
- INTEGRATION_CLIENT=go
Expand Down
11 changes: 0 additions & 11 deletions jest.config.js
View file
Open in desktop

This file was deleted.

Loading