Skip to content

[0.81] [ios][precompile] Use correct version of jsi.cpp #1091

@gabrieldonadel

Description

@gabrieldonadel

Target Branch

0.81

Link to commit or PR to be picked

facebook/react-native#53266

Description

When building the xcframeworks on iOS we're including the file jsi/jsi.cpp in the Swift Package. This file is also included in Hermes and React Native should use the hermes version of these symbols. This is even described (but overlooked) in the React-jsi podspec file.

This causes the error seen in the bug addressed by this commit.

The fix is to exclude the jsi/jsi.cpp file from the jsi target in our swift package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type Pick RequestPick requests to include commits inside a React Native release

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions