Fix inconsistent switch case syntax

[theodorejb]

This must have been a typo, since it's the only instance where the non-standard syntax is used.

[WyriHaximus]

Hey, thanks @theodorejb for taking the time to file this PR. There are two things that bother me with this:

• We have 10+ pairs of eyes on this and none of them spotted this across two PR, how did you find it? Did you ran into some kind of issue?
• Why didn't our tests catch this 😅

[theodorejb]

@WyriHaximus I ran a script across the top Composer packages to find any that were using the alternate switch case syntax, since I'm considering writing an RFC to deprecate it. In the top 1000 packages, this was one of only two where I found it used. All usages appeared to be typos (randomly mixed in with case statements using the standard syntax).

PHP-CS-Fixer will automatically find/fix these issues when using the @PER-CS ruleset (or even the old @PSR2 ruleset).

[WyriHaximus]

@theodorejb Ahh cool thanks, and tbh been doing PHP for 20+ years and only learned today this is valid syntax 🤦 . And honestly that RFC makes sense.

[clue]

@theodorejb TIL! Thanks for looking into this and best of luck with that RFC 👍

(I've marked this as maintenance to emphasize this shouldn't otherwise affect how this code functions.)

[jrfnl]

Could this fix please be released with due haste ?

The PHP 8.5 deprecation has been merged into PHP core and the nightly build for setup-php has been updated (at least the Windows image, the Linux one seems to still lag behind).

This effectively means that the deprecation notice for the code in the 3.2.0 version is currently causing composer installs to fail on PHP 8.5, which means other projects can no longer test against PHP 8.5 to assess their own readiness.

[jrfnl]

For the record, this is the error I'm seeing: