Test reading and writing from and to binary files #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
binairy-file-read-write
branch
from
39b9300 to
9ce450a
Compare
Member
Author
Member
|
Not a big fan of the overhead that base64 encoding incurs, but seeing it fixes a relevant bug, I'm okay with this for now 👍 |
clue
approved these changes
Aug 2, 2018
jsor
approved these changes
Aug 2, 2018
Member
Author
|
@clue neither am I, but I'm up for suggestions in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Closes #38