Skip to content

Always wrap Stream if SSL #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cboden merged 1 commit into from
Mar 20, 2015
Merged

Always wrap Stream if SSL #26

cboden merged 1 commit into from
Mar 20, 2015

Conversation

@cboden
Copy link
Contributor

@cboden cboden commented Feb 3, 2015

refs #24

@cboden cboden added this to the v0.4.3 milestone Feb 3, 2015
@cboden
Copy link
Contributor Author

cboden commented Feb 3, 2015

The buffer drain fix in PHP was reverted. When using SSL we're not correctly notified when the buffer has data therefore must always forcefully drain the buffer. :-(

I left the wrapSecure code in, hopefully PHP core will fix the bug and we can re-add the version check so we don't have to have to do this work around on newer versions of PHP.

@cboden cboden changed the title Always Stream if SSL Always wrap Stream if SSL Feb 3, 2015
@clue
Copy link
Contributor

clue commented Feb 5, 2015

LGTM 👍

Just for the reference: This PR amends PR #14.

@clue
Copy link
Contributor

clue commented Feb 5, 2015

BTW, this could use a test, see #16 or #18.

@clue clue mentioned this pull request Feb 22, 2015
Merged
@cboden cboden merged commit b302dfc into master Mar 20, 2015
@cboden cboden deleted the ssl-refix branch March 20, 2015 16:02
@cboden cboden mentioned this pull request May 4, 2015
Closed
@clue clue mentioned this pull request Nov 22, 2015
Merged
@mcrumm mcrumm mentioned this pull request Dec 17, 2015
Closed
@clue clue mentioned this pull request Mar 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@clue clue

Labels

None yet

Projects

None yet

Milestone

v0.4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@cboden @clue