Skip to content

Conversation

sqts
Copy link
Contributor

@sqts sqts commented Feb 10, 2019

Вопросы, которые возникли:

  • Где нужно писать хуки с большой буквы? В заголовках, в ссылках, в самом тексте?
  • Reducer -> редьюсер или редуктор?

Еще, во втором коммите я пофиксил баги с анкорами на этой странице. Кстати, в продакшен версии они тоже есть сейчас.

@sqts sqts mentioned this pull request Feb 10, 2019
88 tasks
@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 10, 2019
@pavelkeyzik
Copy link
Contributor

Тоже интересовался вопросом про хуки. Только сейчас заметил, что хуки везде с маленькой https://github.com/reactjs/ru.reactjs.org/blob/master/TRANSLATION.md. И так же тут написано, что reducer -> редьюсер

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарии для улучшения перевода

@another-guy another-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 12, 2019
@lex111 lex111 removed the work in progress Author opened the pull-request but it's still being worked on label Feb 16, 2019
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ревью готово. Некоторые предложения о грамматике/пунктуации, другие -- о стиле, а последние -- всё вместе.

Большое спасибо за перевод ❗️

@another-guy another-guy removed the needs review A pull request ready to be reviewed label Feb 16, 2019
@lex111 lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 17, 2019
@lex111
Copy link
Member

lex111 commented Feb 21, 2019

@Hisagr вы можете принять предложенные правки?

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ru-reactjs failed.

Built with commit 7cad409

https://app.netlify.com/sites/ru-reactjs/deploys/5c6f32b427e24a0008363ebc

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ru-reactjs failed.

Built with commit 7cad409

https://app.netlify.com/sites/ru-reactjs/deploys/5c6f32b55c8f85000b99065d

@another-guy another-guy removed the work in progress Author opened the pull-request but it's still being worked on label Feb 22, 2019
@another-guy another-guy merged commit ee58002 into reactjs:master Feb 22, 2019
@another-guy another-guy added the needs proofread A read-through is still needed to release the document label Feb 22, 2019
@another-guy
Copy link
Collaborator

@Hisagr 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants