Skip to content

Fix: Add missing Chat.js and complete ContactList.js dispatch logic i… #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vaibhavibaware
Copy link

This PR addresses two key issues in the Messenger example on the useReducer tutorial page:

  1. Adds a missing Chat.js component file, which is referenced in Messenger.js.
  2. Completes the dispatch logic in ContactList.js by handling the changed_selection action correctly.

fixes #7898

Copy link

meta-cla bot commented Aug 2, 2025

Hi @vaibhavibaware!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

github-actions bot commented Aug 2, 2025

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

meta-cla bot commented Aug 2, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Aug 2, 2025
@gaearon
Copy link
Member

gaearon commented Aug 2, 2025

There's nothing to be fixed here.

The code you're editing is a challenge: https://react.dev/learn/extracting-state-logic-into-a-reducer#dispatch-actions-from-event-handlers

The challenge is intended to be completed by the reader, so the TODOs are for the reader. And as your PR shows, editing the provided files is enough to complete the challenge.

Your PR also does not "add Chat.js file", and that file is not actually missing.

@gaearon gaearon closed this Aug 2, 2025
@vaibhavibaware vaibhavibaware deleted the fix/missing-components-messenger branch August 2, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typo]: Missing code for ContactList and Chat components in useReducer example
2 participants