Skip to content

Conversation

jquense
Copy link
Member

@jquense jquense commented Jul 13, 2023

Want to actually test some of these hooks against react 18, but will do that in another PR

@jquense jquense requested a review from kyletsang July 13, 2023 18:34
Copy link
Collaborator

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment, but LGTM

initialValueFactory: () => T,
) {
const ref = useRef<T>(dft)
const ref = useRef<T>(dft as any)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as T work here?

@jquense jquense merged commit e84ef60 into master Jul 13, 2023
@jquense jquense deleted the jq/bump branch July 13, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants