ActionSheetIOS.showShareActionSheetWithOptions

[Arjan-Zuidema]

Ask your Question

Why use ActionSheetIOS.showShareActionSheetWithOptions on iOS when not using urls?
This currently crashes on iOS 13, but has been fixed in RNShare.open

[jgcmarins]

Hello @Arjan-Zuidema.
Thanks for your question.
I am afraid I couldn't understand what you mean. Could you give an example or link to piece of code?
Thanks.

[Arjan-Zuidema]

When using Share.open with the option urls not set it internally uses ActionSheetIOS.showShareActionSheetWithOptions

Why? Because there was a bug fixed in this package for iOS 13 that a successCallback was called twice which has not been fixed in react-native. So when using Share.open it still crashes because of the react-native bug

[jgcmarins]

Got it.
You mean this one: #584 ?

[Arjan-Zuidema]

Almost. That codes fixes using options.urls. But when I use options.url, the code uses the react-native Share module, which stil has that same bug that was fixed in #584. See this if statement in de code

[jgcmarins]

Now I get it.
Great appointment. Do you have any solution?
Mind to send a PR?

[tomtargosz]

Just a heads up, I submitted a PR to React Native for this bug and the fix got merged in a few days ago. Not sure how long it will take to make it to a release though.

facebook/react-native#26429

[tomtargosz]

My fix has been merged into React Native, this issue shouldn't happen as of RN 0.61.1

https://github.com/facebook/react-native/blob/0.61-stable/Libraries/ActionSheetIOS/RCTActionSheetManager.m

[jgcmarins]

That's great!

[Arjan-Zuidema]

Still I think a dependency of the Share module from react-native should not be necessary, just to prevent things like this in the future.

[tomtargosz]

I agree, better to keep as much of the code in this repo as possible. Just wanted to let people know there's a solution now.