Skip to content

(fix)(android) regression: declare final for removeSessionCookies's promise #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

(fix)(android) regression: declare final for removeSessionCookies's promise #149

merged 1 commit into from
May 11, 2022

Conversation

Poheart
Copy link
Contributor

@Poheart Poheart commented May 3, 2022

This resolves build issues #146 and #148 on Android. Tested /w API 30, no observable build/metro issue.

@Poheart
Copy link
Contributor Author

Poheart commented May 10, 2022 •
edited
Loading

I've upgraded my project and re-tested it against [email protected] with [email protected] without issues.

Bumping this as the current latest published package (6.2.0) is still breaking for the android build.
@safaiyeh let me know if there are any concerns about merging this fix, thanks!

@Poheart Poheart changed the title fix regression causing android build error on 6.1.0 (fix) regression: declare final for removeSessionCookies's promise May 10, 2022
@Poheart Poheart changed the title (fix) regression: declare final for removeSessionCookies's promise (fix)(android) regression: declare final for removeSessionCookies's promise May 10, 2022
@safaiyeh
Copy link
Member

Thanks for the quick fix

@safaiyeh safaiyeh merged commit 7d65519 into react-native-cookies:master May 11, 2022
safaiyeh pushed a commit that referenced this pull request May 11, 2022
@semantic-release-bot
chore(release): 6.2.1 [skip ci]
e0ed1f0 
## [6.2.1](v6.2.0...v6.2.1) (2022-05-11)

### Bug Fixes

* **Android:** android build error incurred from 6.1.0 ([#149](#149)) ([7d65519](7d65519))
* **iOS:** Clear cookie belonging to specified url ([#147](#147)) ([9867cbd](9867cbd))
@safaiyeh
Copy link
Member

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yasithA yasithA yasithA approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poheart @safaiyeh @yasithA