feat: create releases where PATCH doesn't have to match react-native #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
commented
Aug 19, 2024
blakef
commented
Aug 19, 2024
Member
|
I'd like for @szymonrybczak to chime on this one and get his opinion here |
cipolleschi
approved these changes
Aug 20, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
This change makes sense to me. I left a few comments but they are mainly nits.
Accepting to unblock.
.github/workflows/release.yaml
Outdated
| inputs: | ||
| version: | ||
| description: "The version of the template we want to release. For example 0.75.0-rc.0" | ||
| description: "The version of the react-native we want to release. For example 0.75.0-rc.0" |
Contributor
There was a problem hiding this comment.
we don't want to release a version of react-native, but a version of the template, don't we?
Collaborator
Author
There was a problem hiding this comment.
Maybe:
"The version of react-native we want the template to use in this release. For example 0.75.0-rc.0."
Is a clearer description of what I intended here.
szymonrybczak
approved these changes
Aug 30, 2024
Collaborator
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
LGTM, let's answer @cipolleschi's comments and we're good to go!
cipolleschi
reviewed
Sep 2, 2024
This feature needs to be released with react-native-community/cli#2475, which decouples the 1:1 release model we have for templates and react-native. Switching users to this is going to be difficult, and should only be rolled asap before 0.76. If we have to release a template fix, then only users with the latest CLI will be able to use that and subsequent versions. I'm not sure of how to clearly communicate that to users. - Added tests - Set dry_run to default
blakef
force-pushed
the
feat/support-new-template-releases
branch
from
fb773c5 to
df950fb
Compare
blakef
added a commit
that referenced
this pull request
Sep 8, 2024
…43) This feature needs to be released with react-native-community/cli#2475, which decouples the 1:1 release model we have for templates and react-native. Switching users to this is going to be difficult, and should only be rolled asap before 0.76. If we have to release a template fix, then only users with the latest CLI will be able to use that and subsequent versions. I'm not sure of how to clearly communicate that to users. - Added tests - Set dry_run to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature needs to be released with react-native-community/cli#2475,
which decouples the 1:1 release model we have for templates and
react-native.
Switching users to this is going to be difficult, and should only be
rolled asap before 0.76. If we have to release a template fix, then only
users with the latest CLI will be able to use that and subsequent
versions.
I'm not sure of how to clearly communicate that to users.
WARNING: Do not merge until:
We have updated the calling step in react-native release step asks the template to publishNo changes needed here.We agree on a version of react-native that wants this to go live. When we do that, if it's 0.75 / 0.74 then also merge it into the 0.75-stable, etc... branch.0.75.2The CLI change (feat: determine react-native → template from npm registry data cli#2475) is committed and published.