Potential v0.66.1 Patch Release

[lunaleaps]

Conversations on this thread are limited to 0.66 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.66.0 cut, with a link to the specific commit hash on main with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

List of cherry picks

• request (fix ios release build via xcode) facebook/react-native@cc59a7c
• facebook/react-native@25a2c60
• Fix Android border positioning regression facebook/react-native#32398 - Android border visual regression

Local commits to backport to main

• revert facebook/react-native@1b0fb9b

Requested but not sure if it should be done:

• revert facebook/react-native@1b0fb9b - a UX regression for pull to refresh
  • To revert on this patch, I think we need to agree that this commit should be reverted on main. Can someone advocate for that? See comment and context.

[mikehardy]

I believe these both need testing but in the continued effort to make the iOS build experience better, these two from @barbieri replace the current workarounds with what appear to be real solutions:

facebook/react-native@a1c445a
facebook/react-native@51bf557

My only hesitation on those (other than "needs testing") is that I'm not sure of the implications with regard to transitive dependencies. Specifically:

• I'm not sure if those also bring in the requirement for cocoapods >= 1.11 or not,
• "deprecate the __apply_Xcode_12_5_M1_post_install_workaround() as it's not needed anymore, at least with recent versions of the dependencies, no patching is required with RCT-Folly" --> do we already transitively depend on "recent version" (and what are those minimum versions?)

So I'm not sure if they fit (or can be made to fit) for a patch release or should wait for 0.67, but they have landed on main branch at least

[lubomyr]

request (fix ios release build via xcode)
facebook/react-native@cc59a7c

[gaodeng]

please revert facebook/react-native@1b0fb9b
Related Discussion
facebook/react-native#31461
facebook/react-native#28236 (comment)

[svbutko]

Android appearance module fix
facebook/react-native@25a2c60

[lunaleaps]

please revert facebook/react-native@1b0fb9b Related Discussion facebook/react-native#31461 facebook/react-native#28236 (comment)

Has this been reverted on main?

[svbutko]

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67:
facebook/react-native@9ae3367

[radko93]

@svbutko I don't that will be included in 0.66.x. You can also upgrade gradle yourself.

[svbutko]

@svbutko I don't that will be included in 0.66.x. You can also upgrade gradle yourself.

That's for the RN template, if it won't be in 0.66.x I mentioned that it would be fine to include it in 0.67

[mikehardy]

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67: facebook/react-native@9ae3367

Just to note that I'm running those locally in 4 react-native 0.66 projects (two of which have big e2e harnesses, 2 of which are deployed on app stores) and they work fine as far as I can tell, no breaks seen when I moved on those

[edit to add that's just a success report, probably doesn't make sense for a patch release as it's not fixing a bug in react-native, per se]

[svbutko]

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67: facebook/react-native@9ae3367

Just to note that I'm running those locally in 4 react-native 0.66 projects (two of which have big e2e harnesses, 2 of which are deployed on app stores) and they work fine as far as I can tell, no breaks seen when I moved on those

[edit to add that's just a success report, probably doesn't make sense for a patch release as it's not fixing a bug in react-native, per se]

Same thing, I just wanted to note about since there's no 0.67 discussion yet

[oblador]

Please revert facebook/react-native@cb0e1d6 or pick facebook/react-native#32398

[mikehardy]

That PR (32398) hasn't landed (since you made it...2 hours ago :-) ) but I just looked and it looks great IMHO