Upcoming v0.63.4 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.3 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[Naturalclar]

Can this fix be cherry picked for v63.4?

Seems like many people are having trouble displaying image on iOS14

facebook/react-native#29420

[mikehardy]

@Naturalclar is there a commit hash from master for that? This thread needs commit hashes from master to have them picked

[Naturalclar]

@mikehardy thanks for pointing me to the right direction!
This should be the commit hash from master
facebook/react-native@123423c

[sunnylqm]

That's already merged into 0.63.2 facebook/react-native@b6ded72

[Naturalclar]

@sunnylqm oops, missed that. Thanks, and sorry about that! I'll mark my comments as resolved.

[xiao99xiao]

I hate to say this again, but the iOS Modal Dismiss issue facebook/react-native#26473 regressed in 0.63.x since the commit alloy/react-native@27a3248 is not merged into master.

Related discussion in 0.62.0 here: #179 (comment)

And there is a new issue about it facebook/react-native#29455 , and a new pull request facebook/react-native#29882 that repeats what we've done in 0.61.x and 0.62.0 once again.

Hope @kelset could have this issue a check. It's pretty depressing that I have to bring it up every major release.

Anyway, hope everyone have a good day😊

[kelset]

Thanks for pointing it out @xiao99xiao, I'll link the PR to the 0.64 issue and link it back to the FB team, hopefully we can get it merged and then we can properly cherry pick.

[omid-ebrahimi]

Can we have this fix facebook/react-native#29295 in 0.63.4? It's a very old issue and we should use a dirty setTimeout(...) workaround to avoid it.

[mikehardy]

@omid-ebrahimi is there a commit hash merged to master that you can reference? This issue is for links to commit hashes that are already merged on master, so they may be cherry-picked

[omid-ebrahimi]

Can we have this fix facebook/react-native#29295 in 0.63.4? It's a very old issue and we should use a dirty setTimeout(...) workaround to avoid it.

@mikehardy here is the related commit: facebook/react-native@f319ff3

[lorenc-tomasz]

I think that this PR should go into 0.63.4: facebook/react-native#30104

[mikehardy]

@lorenc-tomasz do you have a commit hash for a commit merged to master? The commit hashes are the thing here - see above comments. Cheers