Kitkat fix #9
Merged
Kitkat fix #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
reviewed
Aug 1, 2017
patches/jsc.patch
Outdated
| #include "DebugHeap.h" | ||
| #include "BAssert.h" | ||
| #include "BPlatform.h" | ||
| +#include <posix_memalign.h> |
Member
There was a problem hiding this comment.
If we are patching this I'd actually prefer if we just remove the place where posix_memalign is being called and add an assert(false) there to make sure the app would crash when it gets to that place (we claim that this code is not being used as it is only used when JSC debugging is enabled)
Contributor
Author
There was a problem hiding this comment.
Can't we just implement posix_memalign as assert(false)?
kmagiera
reviewed
Aug 1, 2017
| #endif | ||
|
|
||
| #endif // !__LP64__ | ||
| #include_next <math.h> |
Member
There was a problem hiding this comment.
add small comment explaning what's going on with this file
Member
|
Id like to avoid issues in the future when we update JSC and it may have
other references to posix_memalign. I'd prefer in that case to learn about
that during compilation not in the runtime.
Now we need to patch file that uses posix_memalign anyways, so it doesn't
make any difference if we replace me malign call with assert(false) but in
my opinion it makes our intent more clear to understand
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8