Skip to content

Conversation

@TMisiukiewicz
Copy link
Collaborator

Summary:

The --npm flag in init command has been deprecated for more than a year now in favor of using --pm flag. Since npm will become a default package manager when initializing new project (#2503), I think it's a good time to remove this flag.

Test Plan:

  1. Run init command locally and use --npm flag
  2. Verify error is displayed:
error: unknown option '--npm'
(Did you mean --pm?)

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added docs Documentation change infra Internal work not facing public APIs labels Sep 13, 2024
@TMisiukiewicz TMisiukiewicz added command: init and removed infra Internal work not facing public APIs labels Sep 13, 2024
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🧹

@thymikee
Copy link
Member

@cortinico this is a small braking change that shouldn't affect too many users, shall we ship it as a part of 0.76 and document in the changelog?

@szymonrybczak
Copy link
Collaborator

@cortinico this is a small braking change that shouldn't affect too many users,

To give more context, this option was deprecated with appropriate warning for 3 major versions already.

@cortinico
Copy link
Member

@cortinico this is a small braking change that shouldn't affect too many users, shall we ship it as a part of 0.76 and document in the changelog?

Yup this sounds reasonable 👍

@szymonrybczak szymonrybczak merged commit a414d98 into react-native-community:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command: init docs Documentation change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants