Skip to content

perf: skip getting package class name inside expo module #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 3 commits into from
Aug 31, 2024
Merged

perf: skip getting package class name inside expo module #2487

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
325e1e3
perf: skip getting package class name inside expo module
szymonrybczak Aug 27, 2024
1b27d05
fix: move early return
szymonrybczak Aug 27, 2024
21af361
fix: replace condition validating expo package with `*Package.kt/java…
szymonrybczak Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions packages/cli-platform-android/src/config/findPackageClassName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,29 @@ export default function getPackageClassName(folder: string) {
let files = getMainActivityFiles(folder);
let packages = getClassNameMatches(files, folder);

if (!packages.length) {
files = getMainActivityFiles(folder, false);
packages = getClassNameMatches(files, folder);
if (packages && packages.length > 0 && Array.isArray(packages[0])) {
return packages[0][1];
}

/*
When module contains `expo-module.config.json` we return null
because expo modules follow other practices and don't implement
ReactPackage/TurboReactPackage directly, so it doesn't make sense
to scan and read hundreds of files to get package class name.

Exception is `expo` package itself which contains `expo-module.config.json`
and implements `ReactPackage/TurboReactPackage`.

Following logic is done due to performance optimization.
*/

if (fs.existsSync(path.join(folder, '..', 'expo-module.config.json'))) {
return null;
}

files = getMainActivityFiles(folder, false);
packages = getClassNameMatches(files, folder);

// @ts-ignore
return packages.length ? packages[0][1] : null;
}
Expand Down