Skip to content

fix(cli): fix ENOWORKSPACES when running any command on latest npm #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 3 commits into from
Jul 15, 2024
Merged

fix(cli): fix ENOWORKSPACES when running any command on latest npm #2457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0a4429
fix(cli): fix `ENOWORKSPACES` when running any command on latest npm
tido64 Jul 15, 2024
dd1e167
fix `npm config` for monorepos
tido64 Jul 15, 2024
39e4dd9
chore: run linter and apply auto-fixes
szymonrybczak Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/cli/src/tools/npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,25 @@ export function isProjectUsingNpm(cwd: string) {
return findUp.sync('package-lock.json', {cwd});
}

const registry = getNpmRegistryUrl();
export const getNpmRegistryUrl = (() => {
// Lazily resolve npm registry url since it is only needed when initializing a
// new project.
let registryUrl = '';
return () => {
if (!registryUrl) {
try {
registryUrl = execSync(
'npm config get registry --workspaces=false --include-workspace-root',
)
.toString()
.trim();
} catch {
registryUrl = 'https://registry.npmjs.org/';
}
}
return registryUrl;
};
})();

/**
* Convert an npm tag to a concrete version, for example:
Expand All @@ -40,7 +58,7 @@ export async function npmResolveConcreteVersion(
packageName: string,
tagOrVersion: string,
): Promise<string> {
const url = new URL(registry);
const url = new URL(getNpmRegistryUrl());
url.pathname = `${packageName}/${tagOrVersion}`;
const resp = await fetch(url);
if (
Expand All @@ -58,11 +76,3 @@ export async function npmResolveConcreteVersion(
const json: any = await resp.json();
return json.version;
}

export function getNpmRegistryUrl(): string {
try {
return execSync('npm config get registry').toString().trim();
} catch {
return 'https://registry.npmjs.org/';
}
}