Skip to content

fix: show only warnings from Yarn when verbose mode is enabled #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Jul 5, 2024
Merged

fix: show only warnings from Yarn when verbose mode is enabled #2445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/cli/src/commands/init/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ interface TemplateReturnType {
// Here we are defining explicit version of Yarn to be used in the new project because in some cases providing `3.x` don't work.
const YARN_VERSION = '3.6.4';

const bumpYarnVersion = async (silent: boolean, root: string) => {
const bumpYarnVersion = async (root: string) => {
try {
let yarnVersion = semver.parse(getYarnVersionIfAvailable());

Expand All @@ -99,14 +99,14 @@ const bumpYarnVersion = async (silent: boolean, root: string) => {
}
await executeCommand('yarn', setVersionArgs, {
root,
silent,
silent: !logger.isVerbose(),
});

// React Native doesn't support PnP, so we need to set nodeLinker to node-modules. Read more here: https://github.com/react-native-community/cli/issues/27#issuecomment-1772626767
await executeCommand(
'yarn',
['config', 'set', 'nodeLinker', 'node-modules'],
{root, silent},
{root, silent: !logger.isVerbose()},
);
}
} catch (e) {
Expand Down Expand Up @@ -286,7 +286,7 @@ async function createFromTemplate({
});

if (packageManager === 'yarn' && shouldBumpYarnVersion) {
await bumpYarnVersion(false, projectDirectory);
await bumpYarnVersion(projectDirectory);
}

loader.succeed();
Expand Down