Skip to content

Conversation

@szymonrybczak
Copy link
Collaborator

Summary:

In this Pull Request I've moved npm to the end of list β†’ removing node_modules at the end of clean command makes sure that we don't remove CLI itself before finish command πŸ˜…

Fixes #2353

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js clean
  1. npm should be always as last item βœ…

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee merged commit d21250a into main Jun 27, 2024
@thymikee thymikee deleted the fix/make-sure-to-delete-node-modules-at-the-end branch June 27, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find module 'execa' when running npx react-native clean

3 participants