feat: Add Running... note to the init command #2305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Feb 21, 2024
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
You can check our e2e tests under __e2e__/init.test.ts. Some will likely fail because this will be logged in the text stream written to snapshots
Co-authored-by: Michał Pierzchała <[email protected]>
Member
Author
Great will wait for test failures to follow up here then |
Member
Author
|
Closing in favor of facebook/react-native#43127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is an implementation part of react-native-community/discussions-and-proposals#759
I'm waiting for the RFC to be approved before we can merge this, but I'd like to get a review.
Test Plan:
@szymonrybczak do you know how I can easily test this?
Checklist