feat(ios): cache last used device #2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMisiukiewicz
approved these changes
Dec 11, 2023
thymikee
reviewed
Dec 11, 2023
| devices: Device[], | ||
| lastUsedIOSDeviceId?: string, | ||
| ): Promise<Device | undefined> { | ||
| const sortedDevices = devices; |
Member
There was a problem hiding this comment.
sortedDevices still references devices and is then mutated. You'd need to copy the devices array to avoid mutating it with unshift on line 49 and splice on 48
szymonrybczak
commented
Dec 11, 2023
cipolleschi
reviewed
Dec 18, 2023
| devices: Device[], | ||
| lastUsedIOSDeviceId?: string, | ||
| ): Promise<Device | undefined> { | ||
| const sortedDevices = [...devices]; |
Contributor
There was a problem hiding this comment.
why are these devices sorted? I don't think they are... This line seems a no-op.
Collaborator
Author
There was a problem hiding this comment.
Not really sorted here, but I needed to create a value to do not mutate params.
cipolleschi
approved these changes
Dec 18, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Just a nit, but overall looks good to me.
szymonrybczak
force-pushed
the
feat/save-last-used-device
branch
from
8e481d2 to
c1fe6ae
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Developers often have a lot of simulators installed on their machines, and if they are running
--list-devicesor--interactivethey need to go through all of them, but by adding simple caching we'll move last used device to the top of the list.Uploading CleanShot 2023-11-07 at 17.06.00.mp4…
Test Plan:
Checklist