Skip to content

chore: end fixed zIndex should smaller than start #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 11, 2025

Summary by CodeRabbit

  • Bug 修复
    • 优化了固定区域中元素的显示层级,使固定列的叠加效果更加准确和一致,从而在复杂布局下提供更直观、稳定的视觉体验。

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 3:40am

Copy link

coderabbitai bot commented Mar 11, 2025

Walkthrough

本次提交主要修改了 getCellFixedInfo 函数中 zIndexReverse 的计算逻辑。当 fixStart 非空时,zIndexReverse 由原先的 colStart 修改为 columns.length + colStart;当 fixEnd 非空时,值由原来的 columns.length * 2 - colEnd 改为 columns.length - colEnd。此次修改调整了固定列的层级计算方式。

Changes

文件 修改摘要
src/.../fixUtil.ts 修改 getCellFixedInfozIndexReverse 计算方式:
- fixStart 分支由 colStart 变为 columns.length + colStart
- fixEnd 分支由 columns.length * 2 - colEnd 变为 columns.length - colEnd

Possibly related PRs

Poem

我是一只灵动的小兔子,
在代码田野中轻快跳跃,
见证变量间的奇妙变幻,
每个数字都像星辰闪耀,
固定层级跳出新节拍,
代码世界亦有诗意徜徉。

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/utils/fixUtil.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f21ae4 and 059d0f3.

⛔ Files ignored due to path filters (4)
  • tests/__snapshots__/ExpandRow.spec.jsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/FixedColumn.spec.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/Summary.spec.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/Table.spec.jsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • src/utils/fixUtil.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test / react component workflow
🔇 Additional comments (2)
src/utils/fixUtil.ts (2)

64-64: 优化了固定左侧列的zIndexReverse计算方式

将固定左侧列的zIndexReversecolStart修改为columns.length + colStart,确保固定左侧列的层级高于固定右侧列。这样的修改使得左侧固定列总是会覆盖右侧固定列,与功能设计目标一致。


69-69: 优化了固定右侧列的zIndexReverse计算方式

将固定右侧列的zIndexReversecolumns.length * 2 - colEnd修改为columns.length - colEnd,这样确保了固定右侧列的层级始终小于固定左侧列。这与PR目标"end fixed zIndex should smaller than start"完全一致。

修改后,对于固定右侧列,其zIndexReverse值范围为1到columns.length,而固定左侧列的zIndexReverse值范围为columns.lengthcolumns.length * 2 - 1,确保了两者不会重叠且保持了正确的层级关系。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (1f21ae4) to head (059d0f3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1249   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          76       76           
  Lines        7419     7419           
  Branches     1145     1145           
=======================================
  Hits         7273     7273           
  Misses        140      140           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ zombieJ merged commit d8def22 into master Mar 11, 2025
12 checks passed
@zombieJ zombieJ deleted the reverse-order branch March 11, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant