Skip to content

fix: recursion lose prefixCls #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix: recursion lose prefixCls #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f433194
fix: recursion lose prefixCls
coding-ice Aug 15, 2024
e685e68
test: case
coding-ice Aug 15, 2024
15cd0fe
test: snap
coding-ice Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/nodeUtil.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ function convertItemsToNodes(
// Group
return (
<MergedMenuItemGroup key={mergedKey} {...restProps} title={label}>
{convertItemsToNodes(children, components)}
{convertItemsToNodes(children, components, prefixCls)}
</MergedMenuItemGroup>
);
}

// Sub Menu
return (
<MergedSubMenu key={mergedKey} {...restProps} title={label}>
{convertItemsToNodes(children, components)}
{convertItemsToNodes(children, components, prefixCls)}
</MergedSubMenu>
);
}
Expand Down
22 changes: 22 additions & 0 deletions tests/MenuItem.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,27 @@ describe('MenuItem', () => {

expect(container.querySelector('li')).toMatchSnapshot();
});

it('should set extra to group option', () => {
const { container } = render(
<Menu
items={[
{
type: 'group',
label: 'Top Menu Group with children',
children: [
{
label: 'Menu Item 1',
key: 'top',
extra: '⌘B',
},
],
},
]}
/>,
);

expect(container.querySelector('li')).toMatchSnapshot();
});
});
});
33 changes: 33 additions & 0 deletions tests/__snapshots__/MenuItem.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,38 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`MenuItem overwrite default role should set extra to group option 1`] = `
<li
class="rc-menu-item-group"
role="presentation"
>
<div
class="rc-menu-item-group-title"
role="presentation"
title="Top Menu Group with children"
>
Top Menu Group with children
</div>
<ul
class="rc-menu-item-group-list"
role="group"
>
<li
class="rc-menu-item"
data-menu-id="rc-menu-uuid-test-top"
role="menuitem"
tabindex="-1"
>
Menu Item 1
<span
class="rc-menu-extra"
>
⌘B
</span>
</li>
</ul>
</li>
`;

exports[`MenuItem overwrite default role should set extra to option 1`] = `
<li
class="rc-menu-item"
Expand Down
Loading