[Popover] Don't continuously observeRect on Popovers that are hidden #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


This pull request:
Fixes #636.
Since, in order to have an
aria-controlsattribute,MenuButtonmerely hides itsPopoverrather than not rendering it, thePopoveris constantly runninggetBoundingClientRectby way ofuseRectwhenever there's aMenuButtonon the page. This change makesPopoverpass theobserveparameter touseRectaccording to itshiddenprop, and adds a storybook example for demoing it.I added the storybook in order to try and break it, i.e. by changing the location of the target while
observewas false, and couldn't manage to do so.