Skip to content

Conversation

@indiesquidge
Copy link
Collaborator

@indiesquidge indiesquidge commented Mar 18, 2020

Summary

The escape-regexp package fails approval when trying to detect the license under which the project is distributed.

image

The package has not been touched in 7 years, and implements a single-line function that can be copied directly into source.


Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other: removes unnecessary old dependency

@enforce-template-use
Copy link

Thank you for the pull request

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85fa753:

Sandbox Source
floral-brook-9noff Configuration

@indiesquidge indiesquidge force-pushed the remove-escape-regexp-dep branch from 27d33b8 to d1c0515 Compare March 18, 2020 00:37
The escape-regexp package fails approval when trying to detect the license
under which the project is distributed.

The package has not been touched in 7 years, and implements a single-line
function that can be copied directly into source.
@indiesquidge indiesquidge force-pushed the remove-escape-regexp-dep branch from d1c0515 to 85fa753 Compare March 18, 2020 01:00
@chaance chaance added the Type: Enhancement General improvements or suggestions label Mar 19, 2020
@chaance chaance merged commit 8a08662 into reach:master Mar 19, 2020
@indiesquidge indiesquidge deleted the remove-escape-regexp-dep branch March 19, 2020 17:20
@indiesquidge
Copy link
Collaborator Author

@chancestrickland I don't mean to be a nuisance but I was wondering if Reach planned on doing a release soon. Unfortunately my company's use of Combobox is blocked in the CI build until this commit is out.

I'd be more than happy to help with testing releases and/or writing up release notes :)

@chaance
Copy link
Member

chaance commented Apr 1, 2020

@indiesquidge Planning on a weekend release with what's merged so far and (hopefully) a few more additions. I've got a handful of TODO comments sprinkled throughout, and more tests modeled after what I have set up currently are always greatly appreciated. I'm still not an expert when it comes to the quirks and nuances of Jest and JS DOM, so you may find some low-hanging fruit in the todos there.

I'm realizing that we could probably get more done with some help, but I need to actively provide guidelines and plans to make that happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement General improvements or suggestions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants