Skip to content

Conversation

@kgoggin
Copy link
Contributor

@kgoggin kgoggin commented Mar 16, 2020

This PR addresses #512 by providing an expanded field in the object passed to ListboxInput's render function. I matched the naming convention already present for ListboxButton's render function. I also updated the docs where using the component in this way is mentioned.

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.tsx entry file
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

@enforce-template-use
Copy link

Thank you for the pull request

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be54333:

Sandbox Source
hopeful-lovelace-8ro80 Configuration

@chaance chaance added the Type: Enhancement General improvements or suggestions label Mar 17, 2020
@chaance chaance merged commit d282430 into reach:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement General improvements or suggestions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants