Simpler slider component #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
added
Type: Enhancement
Fix tooltips flicker
* dialog: add accessibilityLabel prop * docs: add new props * dialog: replace accessibilityLabel with aria-label and add documentation * dialog: rename type check function * dialog: error message refinements
This should be the last of the relative imports in the examples.
Member
Author
|
@mjackson Friendly reminder that, if you do want to add this to a non-beta release tomorrow, we want to merge this PR first! |
chaance
pushed a commit
that referenced
this pull request
Oct 23, 2019
* slider: make constant casing consistent with other constants in the project * slider: add simplified slider component * update slider examples * docs: update slider docs * slider: remove useless roles * Do not delete .env in clean script * Auto-deploy website * Allow empty commits * Update build link * Update docs link, website instructions * Rename Jest transformer file * Fix all tooltips showing on initial render * Consolidate ESLint config in repo root * Remove extraneous symlink * Remove unused vars * gitignore website dist files * dialog: Add warnings and documentation to catch missing labels (#317) * dialog: add accessibilityLabel prop * docs: add new props * dialog: replace accessibilityLabel with aria-label and add documentation * dialog: rename type check function * dialog: error message refinements * normalize id formatting * add makeId to utils * Import styles as users do in examples (#320) * add open collective support * add contributor graph to readme * add alt attribute to graph * Add documentation for ignoring CSS warnings in tests (#328) * docs: minor re-phrasing * Add release instructions to the README * slider: make constant casing consistent with other constants in the project * slider: add simplified slider component * update slider examples * docs: update slider docs * slider: remove useless roles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the current
Slidercomponent toSliderInput, which becomes the composable API. We would then useSliderand a simplified version that can be used in isolation the same way an HTML range input is used. Any of the following would work