Cleanup/refactor #33
Merged
Cleanup/refactor #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunnymatic
force-pushed
the
chores/cleanup-and-refactor
branch
3 times, most recently
from
268a694 to
00b62b4
Compare
Problem -------- Running `rubocop` indentified a lot of little issues for cleanup. In doing this cleanup, there was some refactoring done that changes the overall API. Deprecation warnings have been added. Solution -------- * Add `Commands` class to pull some command running helpers out of the main module * Don't mix in ImageMagick::Fonts (which removes `MojoMagick.get_fonts` method) * Add deprecation warnings for missing methods * rubocop cleanup * make test methods shorter and better named * Move from `Parser` to `FontParser` and add deprecations * Sequester deprecated methods for easy removal later * Add rubocop check to circle * Update readme to reflect moves
bunnymatic
force-pushed
the
chores/cleanup-and-refactor
branch
from
00b62b4 to
fae5c0e
Compare
This was referenced Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
rubocopindentified a lot of little issues for cleanup.In doing this cleanup, there was some refactoring done that changes the
overall API for a few things. There will be deprecation warnings for the functions that have been moved/removed.
Changes
MojoMagick::get_fontsrenamed toMojoMagick::available_fontsexecute!andexecuteandraw_commandmethods intoMojoMagick::CommandsMojoMagick::Util::ParsertoMojoMagick::Util::FontParserImageMagick::Fontsand letavailable_fontsprovide the font list (this effectively removesMojoMagic::get_fonts. You can get the same functionality fromMojoMagick::available_fonts)