fix: Made backward compatible for getting currency #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use get_currency() or get_order_currency() based on the WooCommerce version.
albingeorge
force-pushed
the
backward_compatibility
branch
from
0d78618 to
5d35c5b
Compare
mayankamencherla
approved these changes
Jul 5, 2017
|
👍 for the quick fix. I'd have preferred a version_compare check though, like we do it in other places. |
|
@captn3m0 I used the same version_compare block we use in prefill arguments for this. |
|
Oops, was not showing in the default diff. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get_currency() or get_order_currency() based on the WooCommerce version.
Tested against the WooCommerce versions 3.1.0 and 2.6.8.