change version to 2.52.0 #58730
change version to 2.52.0 #58730
Conversation
Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
requested review from
a team,
SongGuyang,
WangTaoTheTonic,
kfstorm and
raulchen
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 2.52.0 across various configuration and source files for the new release. The changes are consistent and correctly applied. I have one suggestion for the java/pom.xml file to remove a redundant property definition, which will improve the maintainability of the build configuration.
| <properties> | ||
| <java.version>1.8</java.version> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.version>2.0.0-SNAPSHOT</project.version> | ||
| <project.version>2.52.0</project.version> | ||
| </properties> |
There was a problem hiding this comment.
The <project.version> property is redundant here. Maven's built-in ${project.version} property automatically gets its value from the project's top-level <version> tag (line 8). Explicitly defining it again in the <properties> section is unnecessary. Removing this redundant definition will simplify the POM and ensure there is a single source of truth for the project version.
<properties>
<java.version>1.8</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
for 2.52 release