Skip to content

Conversation

Aydin-ab
Copy link
Contributor

@Aydin-ab Aydin-ab commented Aug 21, 2025

Why are these changes needed?

Adding new ray serve llm deployment examples for both ray docs and Anyscale templates:

  • small size llm (single node, 1 gpu) + also show a gated model example with llama 3.1
  • medium size llm with tensor parallelism (single node, 2-8 gpus) + also show a gated model example with llama 3.1
  • vision llm (sending images, limit # of images per prompt, link to vllm multimodal docs)
  • reasoning llm (setup a reasoning parser in LLMConfig, how to parse reasoning vs main content)
  • hybrid reasoning llm (setup a reasoning parser in LLMConfig, turn on/off reasoning in a request)
  • Also introduce deployment in Anyscale Service, but not too much to not turn off OSS readers

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Aydin Abiar added 16 commits August 19, 2025 18:37
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
@Aydin-ab Aydin-ab requested a review from a team as a code owner August 21, 2025 20:21
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive set of examples for deploying various types of LLMs with Ray Serve, which is a fantastic addition to the documentation. The examples cover different model sizes and functionalities, providing valuable guidance. My review includes several suggestions to fix broken links, correct inconsistencies in model and file names, and resolve some code errors that would prevent the examples from running. Addressing these points will significantly improve the clarity and correctness of the new documentation.

Aydin Abiar and others added 8 commits August 21, 2025 13:25
Signed-off-by: Aydin Abiar <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue docs An issue or change related to documentation llm labels Aug 22, 2025
Aydin Abiar added 8 commits September 2, 2025 20:39
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
@Aydin-ab
Copy link
Contributor Author

Aydin-ab commented Sep 3, 2025

@khluu
Hi Kevin, FYI, I deleted the old Bazel in the tutorials/ folder as it didn't seem to do anything. It takes precedence over the root BUILD.bazel which might cause confusion for future changes here

Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Copy link
Contributor

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped.. that BUILD file was modified a long time ago and doesn't seem to be used anywhere in the codebase

@angelinalg angelinalg merged commit 7e59dd8 into ray-project:master Sep 4, 2025
5 checks passed
@Aydin-ab Aydin-ab deleted the example-serve-llm-deployment branch September 5, 2025 00:13
sampan-s-nayak pushed a commit to sampan-s-nayak/ray that referenced this pull request Sep 8, 2025
Aydin-ab added a commit to Aydin-ab/ray-aydin that referenced this pull request Sep 8, 2025
Aydin-ab added a commit to Aydin-ab/ray-aydin that referenced this pull request Sep 8, 2025
aslonnie pushed a commit that referenced this pull request Sep 8, 2025
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
wyhong3103 pushed a commit to wyhong3103/ray that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests llm serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants