Skip to content

[doc] remove protobuf<3 pinning in examples #55242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Aug 5, 2025

we are already using protobuf>=4.

@aslonnie aslonnie requested a review from a team as a code owner August 5, 2025 05:48
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@aslonnie aslonnie force-pushed the lonnie-250804-pblt3 branch 2 times, most recently from 54ce6d3 to 7742823 Compare August 5, 2025 05:49
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Aug 5, 2025
@aslonnie aslonnie force-pushed the lonnie-250804-pblt3 branch from 7742823 to ae912a4 Compare August 5, 2025 08:57
@aslonnie aslonnie requested a review from a team as a code owner August 5, 2025 08:57
ray images are already using `protobuf>=4`

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-250804-pblt3 branch from ae912a4 to 6645c7b Compare August 5, 2025 09:00
Copy link
Contributor

@eicherseiji eicherseiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/source/templates/testing/cluster_envs/04_finetuning_llms_with_deepspeed.yaml will be removed in an upcoming PR

@aslonnie aslonnie merged commit 7c7222e into master Aug 5, 2025
5 checks passed
@aslonnie aslonnie deleted the lonnie-250804-pblt3 branch August 5, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants