-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Added Ray Train LoggingManager Utility Class #55121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ray Train LoggingManager Utility Class #55121
Conversation
…anage the configuration of Ray Train logging Signed-off-by: JasonLi1909 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JasonLi1909, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the logging infrastructure within Ray Train by consolidating various logging utility functions into a dedicated LoggingManager
class. This change aims to improve the modularity, maintainability, and overall organization of the logging code, making it easier to manage and extend in the future.
Highlights
- Code Organization: Introduced a new
LoggingManager
utility class within Ray Train's logging module to centralize and group related logging functions. - Refactoring: Existing standalone logging utility functions, such as those for configuring controller and worker loggers and retrieving log directories, have been refactored and moved into the
LoggingManager
as static methods. - API Update: All internal call sites across the
controller
,worker
, andtest_logging
modules have been updated to invoke these logging functionalities through the newly introducedLoggingManager
class, ensuring consistent usage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a LoggingManager
utility class to Ray Train's logging module for grouping logging utility functions. The changes involve refactoring existing logging functions into static methods within the new class and updating associated call sites. The use of a utility class improves code organization and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good after this one comment!
Co-authored-by: Justin Yu <[email protected]> Signed-off-by: Jason Li <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Jason Li <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: Kamil Kaczmarek <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Jason Li <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: Michael Acar <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Jason Li <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: elliot-barn <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Jason Li <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: sampan <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Jason Li <[email protected]> Co-authored-by: Justin Yu <[email protected]> Signed-off-by: jugalshah291 <[email protected]>
Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary.