Skip to content

Conversation

JasonLi1909
Copy link
Contributor

Added a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. Also modified associated test cases as necessary.

…anage the configuration of Ray Train logging

Signed-off-by: JasonLi1909 <[email protected]>
@JasonLi1909 JasonLi1909 requested a review from a team as a code owner August 1, 2025 01:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @JasonLi1909, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the logging infrastructure within Ray Train by consolidating various logging utility functions into a dedicated LoggingManager class. This change aims to improve the modularity, maintainability, and overall organization of the logging code, making it easier to manage and extend in the future.

Highlights

  • Code Organization: Introduced a new LoggingManager utility class within Ray Train's logging module to centralize and group related logging functions.
  • Refactoring: Existing standalone logging utility functions, such as those for configuring controller and worker loggers and retrieving log directories, have been refactored and moved into the LoggingManager as static methods.
  • API Update: All internal call sites across the controller, worker, and test_logging modules have been updated to invoke these logging functionalities through the newly introduced LoggingManager class, ensuring consistent usage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a LoggingManager utility class to Ray Train's logging module for grouping logging utility functions. The changes involve refactoring existing logging functions into static methods within the new class and updating associated call sites. The use of a utility class improves code organization and maintainability.

Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after this one comment!

@JasonLi1909 JasonLi1909 added the go add ONLY when ready to merge, run all tests label Aug 4, 2025
@justinvyu justinvyu enabled auto-merge (squash) August 4, 2025 21:22
@justinvyu justinvyu merged commit 4ec0f69 into ray-project:master Aug 4, 2025
7 checks passed
kamil-kaczmarek pushed a commit that referenced this pull request Aug 4, 2025
Added a LoggingManager utility class to Ray Train's logging module for
grouping logging utility functions. Also modified associated test cases
as necessary.

---------

Signed-off-by: JasonLi1909 <[email protected]>
Signed-off-by: Jason Li <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Signed-off-by: Kamil Kaczmarek <[email protected]>
mjacar pushed a commit to mjacar/ray that referenced this pull request Aug 5, 2025
Added a LoggingManager utility class to Ray Train's logging module for
grouping logging utility functions. Also modified associated test cases
as necessary.

---------

Signed-off-by: JasonLi1909 <[email protected]>
Signed-off-by: Jason Li <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Signed-off-by: Michael Acar <[email protected]>
elliot-barn pushed a commit that referenced this pull request Aug 5, 2025
Added a LoggingManager utility class to Ray Train's logging module for
grouping logging utility functions. Also modified associated test cases
as necessary.

---------

Signed-off-by: JasonLi1909 <[email protected]>
Signed-off-by: Jason Li <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
sampan-s-nayak pushed a commit that referenced this pull request Aug 12, 2025
Added a LoggingManager utility class to Ray Train's logging module for
grouping logging utility functions. Also modified associated test cases
as necessary.

---------

Signed-off-by: JasonLi1909 <[email protected]>
Signed-off-by: Jason Li <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Signed-off-by: sampan <[email protected]>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
Added a LoggingManager utility class to Ray Train's logging module for
grouping logging utility functions. Also modified associated test cases
as necessary.

---------

Signed-off-by: JasonLi1909 <[email protected]>
Signed-off-by: Jason Li <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Signed-off-by: jugalshah291 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants