[Data] Cleaning up ExecutionResources

[alexeykudinkin]

Why are these changes needed?

Cleaning up ExecutionResources:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[gemini-code-assist]

Summary of Changes

Hello @alexeykudinkin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ExecutionResources class within Ray Data to improve its robustness and predictability. The primary goals are to make ExecutionResources objects effectively immutable, standardize the handling of zero and null resource values, and ensure all resource quantities are properly rounded to align with Ray Core's resource quantization.

Highlights

• Enforced Immutability: The direct setters for resource properties (cpu, gpu, memory, object_store_memory) have been deprecated. Instead, the copy() method has been enhanced to allow creating a new ExecutionResources instance with specific resource overrides, promoting a functional, immutable pattern for resource management.
• Standardized Resource Initialization and Null Handling: The ExecutionResources constructor and from_resource_dict method now consistently initialize resource attributes to 0.0 (or rounded values) if not explicitly provided, eliminating the need for the default_to_inf flag and simplifying resource interpretation.
• Precise Resource Quantization: New helper functions safe_round and safe_or have been introduced to ensure that all resource values are rounded to the 5th decimal place, matching Ray Core's internal resource allocation granularity, and to provide robust handling of None values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request cleans up the ExecutionResources class by making it immutable, fixing the handling of zeros and nulls, and adding proper rounding. The changes are well-structured and the new helper functions are a good addition. To maintain consistency, the deprecated setters should be consistent with the constructor's rounding logic.

[gemini-code-assist]

Consider rounding the input value in the deprecated setter for consistency with the constructor.[^1] The constructor rounds resource values to the 5th decimal digit, but the setter does not, which could lead to unexpected behavior if the setter is used.

self._cpu = safe_round(value, 5) or 0.0

[gemini-code-assist]

Consider rounding the input value in the deprecated setter for consistency with the constructor.[^1] The constructor rounds resource values to the 5th decimal digit, but the setter does not, which could lead to unexpected behavior if the setter is used.

self._gpu = safe_round(value, 5) or 0.0

[raulchen]

what is the the behavior when ndigit is None? Can you add a comment?

[alexeykudinkin]

ndigits=None is Python's default

https://docs.python.org/3/library/functions.html#round

[raulchen]

nice. Can you also update existing use cases?
If too many, we can just update the ones on the critical path first.

[alexeykudinkin]

Was doing that in separate PR, but fair enough

[angelinalg]

stamp