[data.llm] Return a batch of rows in the udf instead of row by row #54329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
|
Running release tests to ensure correctness: https://buildkite.com/ray-project/release/builds/47502 |
alexeykudinkin
approved these changes
Jul 3, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
lk-chen
approved these changes
Jul 7, 2025
8 tasks
8 tasks
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Jul 9, 2025
…ay-project#54329) Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: doyoung <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Jul 9, 2025
…ay-project#54329) Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: doyoung <[email protected]>
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
…ay-project#54329) Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this PR there is a lot of overhead when returning each row as its own batch with bsize=1 in an async generator udf. This PR fixes is by returning a batch.
There is an argument that we are sacrificing throughput by making items in a batch sync but that there is even a bigger overhead now because of yielding each at row levels.