[Train] Remove the subclass relationship between RunConfig and RunConfigV1 #54293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xgui <[email protected]>
xinyuangui2
changed the title
justinvyu
reviewed
Jul 3, 2025
Signed-off-by: xgui <[email protected]>
justinvyu
approved these changes
Jul 3, 2025
Signed-off-by: xgui <[email protected]>
Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 7, 2025
…figV1 (#54293) In RunConfig, it subclasses RunConfigV1, whose `__post_init__` is using v1 configs to initialize. Now we remove the subclass relationship to avoid unexpected bugs. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: elliot-barn <[email protected]>
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
…figV1 (ray-project#54293) In RunConfig, it subclasses RunConfigV1, whose `__post_init__` is using v1 configs to initialize. Now we remove the subclass relationship to avoid unexpected bugs. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In RunConfig, it subclasses RunConfigV1, whose
__post_init__is using v1 configs to initialize.Now we remove the subclass relationship to avoid unexpected bugs.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.